🐛 Fix leader elect helm chart args

[nikParasyr]

What this PR does / why we need it:
Fix small typo in helm chart for leader election
related arguments

Related logs:

unknown flag: --leader-election-lease-duration
Usage of /manager:
      ...
      --leader-elect-lease-duration duration   Interval at which non-leader candidates will wait to force acquire leadership (duration string) (default 15s)
      --leader-elect-renew-deadline duration   Duration that the leading controller manager will retry refreshing leadership before giving up (duration string) (default 10s)
      --leader-elect-retry-period duration     Duration the LeaderElector clients should wait between tries of actions (duration string) (default 2s)
      ...

Would be nice if we can get a new helm chart version released after it is merged (although not critical to have)

[k8s-ci-robot]

Welcome @nikParasyr!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nikParasyr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alexander-demicev]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demicev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[furkatgofurov7]

/ok-to-test

[nikParasyr]

@furkatgofurov7 The failed test seems unrelated with the changes of this PR. Specifically it fails on:

Create, upgrade, downgrade and delete providers with minimal specified configuration [It] should successfully create and delete an AddonProvider
/home/prow/go/src/sigs.k8s.io/cluster-api-operator/test/e2e/minimal_configuration_test.go:213
  [FAILED] Timed out after 180.002s.
  Deployment capi-operator-system/caaph-controller-manager failed to get status.Available = True condition
  Deployment:
  {
    "metadata": {
      "creationTimestamp": null
16 skipped lines...
  Expected
      <bool>: false
  to be true
  In [It] at: /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.5.2/framework/deployment_helpers.go:88 @ 10/18/23 13:40:23.448Create, upgrade, downgrade and delete providers with minimal specified configuration [It] should successfully create and delete an AddonProvider
/home/prow/go/src/sigs.k8s.io/cluster-api-operator/test/e2e/minimal_configuration_test.go:213
  [FAILED] Timed out after 180.002s.
  Deployment capi-operator-system/caaph-controller-manager failed to get status.Available = True condition
  Deployment:
  {
    "metadata": {
      "creationTimestamp": null
16 skipped lines...
  Expected
      <bool>: false
  to be true
  In [It] at: /home/prow/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.5.2/framework/deployment_helpers.go:88 @ 10/18/23 13:40:23.448

This issue could be related to it => kubernetes-sigs/cluster-api-addon-provider-helm#129, although im not sure which version of caaph is the CI trying to install

[nikParasyr]

/retest

[furkatgofurov7]

This issue could be related to it => kubernetes-sigs/cluster-api-addon-provider-helm#129, although im not sure which version of caaph is the CI trying to install

@nikParasyr I think you are right, the new release was cut recently, and we started seeing the same errors in other PRs in the repo. @alexander-demicev we do not specify caaph version in the repo AFAIK, but rather use the latest version (which happens to be v0.1.0-alpha.10) coming from CAPI ?

[furkatgofurov7]

Reached out to caaph maintainers on slack to ask what is up with latest release images, xref: https://kubernetes.slack.com/archives/C05AWPWF2HL/p1697643138969759

[alexander-demicev]

/retest

[nikParasyr]

/retest

[nikParasyr]

/retest

[nikParasyr]

CAAPH still is failing. Opened a new issue to tackle it => kubernetes-sigs/cluster-api-addon-provider-helm#131

[alexander-demicev]

/retest

[alexander-demicev]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 82f676d046b836ff56e15dc80803c8081d351440