Skip to content

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 28, 2023

What this PR does / why we need it:
Now dependabot doesn't update dependencies for some modules, which which breaks consistency between them.

This PR enables dependabot for 3 remaining modules: test, hack/tools and hack/chart-update.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Now dependabot doesn't update dependencies for some modules, which
which breaks consistency between them.

This PR enables dependabot for 3 remaining modules: test, hack/tools
and hack/chart-update.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion, there is a new dependabot feature that you can group updates. See example in https://github.com/kubernetes-sigs/cluster-api/pull/9263/files.

We can do a follow-up, or use the same PR, leaving it up to you 🙂

@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 28, 2023

@furkatgofurov7 thanks for letting me know! I would prefer to implement it in in another PR as it's not strictly related to this one.

Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d53f598895fca4c2b8c650b68aea28999823e82

Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6e8e046 into kubernetes-sigs:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants