🌱 Split out test modules from capi operator modules

[Danil-Grigorev]

What this PR does / why we need it:

This small change separates capi operator modules from test suite, allowing independent use and external imports. Removes core dependency on capi testing framework. Follows similar pattern to CAPI test suite

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[Fedosin]

/approve

awesome! thank you for doing this.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Fedosin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[furkatgofurov7]

This looks good, apart couple of suggestions:

• since we have separated now test modules into its own folder and we ship it with its own Go module, we most probably should:
  • add notes informing about this change properly
  • tag and version the new module as part of the release. We would have to create an annotated tag for /test folder and push it every time we do a release from the repo, once this goes in. For example, if we're releasing v0.5.0, we should also tag test/v0.5.0. Also related release docs has to be updated, i.e:

   1. Create an annotated tag:
  
  - git tag -a -s v0.x.y -m v0.x.y
  - git tag -a -s test/v0.x.y -m test/v0.x.y
  
  2. Push the tags to the GitHub repository:
  
  - git push origin v0.x.y
  - git push origin test/v0.x.y`
  

  should work.
  • add a path to new go.mod/sum files in the Makefile modules target where we run gomod tidy in all folders where we have go.mod/sum files and verify-modules target
  • add it to Dockerfile in https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/Dockerfile#L29-L31

[alexander-demicev]

/lgtm
Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 77f53d97cb5587ce6707abb261a51c93b4ba16c5

[alexander-demicev]

/hold

[alexander-demicev]

I don't know if comments from @furkatgofurov7 are blocking so I put the PR on hold, feel free to remove it if needed

[Danil-Grigorev]

Everything fixed. @furkatgofurov7 I think nothing is pending

[furkatgofurov7]

Last nit:

[furkatgofurov7]

let's sign this tag with gpg signature as above?

[Danil-Grigorev]

This process is coming from CAPI release document. They explicitly don’t sign test package. I’m not sure why exactly, but I’d rather stick with existing process for now: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-tasks.md#repeatedly-cut-a-release-1

[furkatgofurov7]

I wonder why, though, but it is fine. Thanks!

/lgtm

[furkatgofurov7]

/hold cancel