🐛 Support installing providers with custom names in air-gapped environments #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Fedosin
changed the title
Fedosin
force-pushed
the
air_gapped_custom_names
branch
from
62de74f to
1254273
Compare
k8s-ci-robot
added
size/M
Fedosin
force-pushed
the
air_gapped_custom_names
branch
from
1254273 to
296aeaa
Compare
k8s-ci-robot
added
size/S
Fedosin
force-pushed
the
air_gapped_custom_names
branch
from
296aeaa to
3d6ed42
Compare
k8s-ci-robot
added
size/M
Currently we do not support installation of providers with custom names for air-gapped environments. It happens because we inject new names in the list of known providers only for those with URL specified, ignoring config maps. This PR fixes it, so we support both URL and ConfigMap installations with custom names.
Fedosin
force-pushed
the
air_gapped_custom_names
branch
from
3d6ed42 to
ae6df92
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 10105e6fe7118be628c0cfd41efdbb3fe3e1554a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we do not support installation of providers with custom names for air-gapped environments. It happens because we inject new names in the list of known providers only for those with URL specified, ignoring config maps.
This PR fixes it, so we support both URL and ConfigMap installations with custom names.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #204