🐛 Do not leave resources on the system after removing a provider #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client proxy defines among which types we will search for objects with the desired labels. Currently this list is not full and we skip some types, like ClusterRole or ClusterRole bindings. It leads to the fact that objects of these types stay in the system when their provider is deleted. This PR updates the list of resource types we need to scan.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Fedosin
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8354a3e9439012248072fa8949a83f04621c5dd1
|
|
/retest |
>_< |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Client proxy defines among which types we will search for objects we need to delete. Currently this list is not full and we skip some types, like ClusterRole or ClusterRole bindings. It leads to the fact that objects of these types stay in the system when their provider is deleted.
This PR updates the list of resource types we need to scan.
Note: for now, we will not delete CRDs and namespaces as it's the default behavior of clusterctl. But we still want to scan them because it will make it easier to manage their removal in the future: https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/internal/controller/phases.go#L413-L417
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #