✨ Add support for ImagePullSecrets in DeploymentSpec

[adriananeci]

What this PR does / why we need it:

In order to be able to pull provider images from a private registry we need to be able to also pass the image pull secrets so that we can authenticate to the registry while pulling the image.

This PR adds support for ImagePullSecrets option in provider DeploymentSpec

[k8s-ci-robot]

Welcome @adriananeci!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @adriananeci. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Fedosin]

/ok-to-test

[alexander-demicev]

thanks!
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexander-demicev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Fedosin]

Probably the best way to deal with the lint issue is to add //nolint:nestif before the if block on line 94

[adriananeci]

Thanks @Fedosin for the suggestion. Even with that statement golangci-lint was still complaining with:

internal/controller/component_customizer.go:94:2: `if pSpec.Deployment != nil` has complex nested blocks (complexity: 5) (nestif)
	if pSpec.Deployment != nil {
	^
internal/controller/component_customizer.go:113:3: directive `//nolint:nestif` is unused for linter "nestif" (nolintlint)
		//nolint:nestif
		^

So I went ahead and commented out the nestif, similar with what you've done in #176

[Fedosin]

Fix for the linter issue: #176

[Fedosin]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d23f2caee78421e4395fa499bffd6b45410215cd

[Fedosin]

@adriananeci thank you for working on this!