🐛 Update provider components if (and only if) its spec has been changed #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Fedosin
changed the title
Fedosin
changed the title
Fedosin
force-pushed
the
applied_spec_hash
branch
from
2e83ed8 to
b5590cb
Compare
Fedosin
force-pushed
the
applied_spec_hash
branch
from
b5590cb to
2d1ff59
Compare
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| if typedProvider.GetAnnotations()[appliedSpecHashAnnotation] == specHash { |
There was a problem hiding this comment.
If I remember it right, GetAnnotations() can still return nil
There was a problem hiding this comment.
Yeah, it can, but it doesn't matter. We can get values from nil maps. Here is an example I wrote: https://go.dev/play/p/pUL9u7U5OyR
To prevent duplicate reconciliation we calculate last applied spec hash and store it in a provider annotation. For next reconciliations we calculate the hash again. If it's the same as in the annotation, we skip further steps and stop immediately.
Now this logic is in the spec hash check, i.e. if provider version has changed, spec hash will be different. So it doesn't make sense to keep duplicate code that does the same.
Fedosin
force-pushed
the
applied_spec_hash
branch
from
2d1ff59 to
fbe6ef4
Compare
|
/retest |
Fedosin
changed the title
alexander-demicev
approved these changes
Jun 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e140c9eea730d59854702a02d8e3f278b0aaf024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Now we update provider components only if it's version has changed, but there are other cases where we need to do the same. For instance, when we update its DeploymentSpec or ManagementSpec.
Also we should reconcile providers if their spec is the same as for the last applied version.
To fix it we calculate last applied spec hash and store it in a provider annotation. For next reconciliations we calculate the hash again. If it's the same as in the annotation, we skip further steps and stop immediately.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #156