Skip to content

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented May 31, 2023

What this PR does / why we need it:
Improves a bit root level README.md document with:

  • removing:
    • generic notes from the scaffolding of the repo
    • link to k8s dev mailing list (please let me know this, happy to link to operator specific mailing list if there is any, but I am not aware of)
  • adds proper link to the operator slack channel

Mainly inspired by the Cluster API repo notes :)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2023
@k8s-ci-robot k8s-ci-robot requested review from damdo and neolit123 May 31, 2023 11:06
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2023
@furkatgofurov7
Copy link
Member Author

/cc @Fedosin

@k8s-ci-robot k8s-ci-robot requested a review from Fedosin May 31, 2023 11:07
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
Copy link
Contributor

@Fedosin Fedosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2190690 into kubernetes-sigs:main May 31, 2023
@furkatgofurov7 furkatgofurov7 deleted the improve-root-readme branch May 31, 2023 12:26
@furkatgofurov7
Copy link
Member Author

This is to test kubernetes/test-infra#29664:

/cherry-pick release-0.2

@k8s-infra-cherrypick-robot

@furkatgofurov7: new pull request created: #127

In response to this:

This is to test kubernetes/test-infra#29664:

/cherry-pick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@furkatgofurov7
Copy link
Member Author

@furkatgofurov7: new pull request created: #127

It seems to work, closing the cherry-pick PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants