Skip to content

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Apr 24, 2023

What this PR does / why we need it:

Current version 1.1 is outdated and not compatible with OCI:

docker pull docker.io/docker/dockerfile:1.1-experimental
Trying to pull docker.io/docker/dockerfile:1.1-experimental...
Error: copying system image from manifest list: initializing image from source docker://docker/dockerfile:1.1-experimental: unsupported docker v2s2 media type: "application/vnd.oci.image.layer.v1.tar+gzip"

To comply with cluster-api repo, we update it to v1.4.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2023
@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 24, 2023

/retest

Current version 1.1 is outdated and not compatible with OCI:
```
docker pull docker.io/docker/dockerfile:1.1-experimental
Trying to pull docker.io/docker/dockerfile:1.1-experimental...
Error: copying system image from manifest list: initializing image from source docker://docker/dockerfile:1.1-experimental: unsupported docker v2s2 media type: "application/vnd.oci.image.layer.v1.tar+gzip"
```
@Fedosin Fedosin force-pushed the bump_dockerfile_image branch from 41e2f4c to a05d853 Compare April 24, 2023 19:28
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7c2da1a into kubernetes-sigs:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants