Add basic aga controller e2e tests #4485
Conversation
k8s-ci-robot
added
cncf-cla: yes
wweiwei-li
force-pushed
the
aga-e2e
branch
2 times, most recently
from
ab72dbe to
3808a8d
Compare
wweiwei-li
changed the title
wweiwei-li
changed the title
|
@wweiwei-li: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shraddhabang, wweiwei-li The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| dnsName := stack.GetGlobalAcceleratorDualStackDNSName() | ||
| listenerPort := 80 | ||
| if len(port) > 0 { | ||
| listenerPort = port[0] |
There was a problem hiding this comment.
Just wondering, why are you using an array when you only use the first value?
| aga = createAGAWithIngressEndpoint(gaName, namespace, acceleratorName, ingName, agav1beta1.IPAddressTypeIPV4, | ||
| &[]agav1beta1.GlobalAcceleratorListener{{ | ||
| Protocol: &protocol, | ||
| PortRanges: &[]agav1beta1.PortRange{{FromPort: 443, ToPort: 443}}, |
There was a problem hiding this comment.
I don't see a test where you validate that we can support a port range e.g. ports 100 to 200.
|
|
||
| // IsCommercialPartition returns true if the region is in the commercial AWS partition | ||
| func IsCommercialPartition(region string) bool { | ||
| unsupportedPrefixes := []string{"cn-", "us-gov-", "us-iso", "eu-isoe-"} |
There was a problem hiding this comment.
nit: Do you have an ARN you can parse instead? If so, it makes this check more robust.
| gwv1 "sigs.k8s.io/gateway-api/apis/v1" | ||
| ) | ||
|
|
||
| var _ = Describe("GlobalAccelerator with Gateway endpoint", func() { |
There was a problem hiding this comment.
Does accelerator controller read the route data? If so, it would be interesting to validate that cross namespace routes work. If the accelerator controller doesn't read route data, then that test case doesn't seem necessarily.
4 participants
Description
Test Files:
Helper Files:
Tests coverred:
Note: These tests require
--enable-aga-testsflag to run (local testing only, not in CI). Make sure set up your local controller with https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/guide/globalaccelerator/installation.mdService Endpoint Tests (service_endpoint_test.go):
✅ IP target type lifecycle - Create, verify, update , verify traffic
✅ Instance target type scheme change - Deploy with internet-facing, change to internal, verify endpoint replacement
✅ Direct endpoint ID - Create GlobalAccelerator with direct load balancer ARN reference
Ingress Endpoint Tests (ingress_endpoint_test.go):
✅ Basic Ingress lifecycle - Create, verify configuration, traffic flow
✅ Auto-discovery - Automatically discover protocol and ports from Ingress
✅ IPV4 to DUAL_STACK migration - Migrate address type and verify dual-stack DNS
✅ Port overrides- Configure port overrides for listeners
Multi-Endpoint Tests (multi_endpoint_test.go):
✅ Service + Ingress endpoints - Multiple endpoint types in same namespace
Gateway Endpoint Tests (gateway_endpoint_test.go):
✅ ALB Gateway endpoint - Create GlobalAccelerator with ALB Gateway, verify configuration and traffic
✅ NLB Gateway endpoint - Create GlobalAccelerator with NLB Gateway, verify configuration and traffic
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯