fix e2e tests

[zac-nixon]

Description

I refactored this logic to reduce code duplication, but used the wrong values. I never re-tested after refactoring :x

test k8s alb gateway using instance targets reconciled by the aws load balancer controller with ALB instance target configuration with basic HTTPRoute should provision internet-facing load balancer resources
/Users/nixozach/go_projects/aws-load-balancer-controller/test/e2e/gateway/alb_instance_target_test.go:55
  {"level":"info","ts":1759792339.536845,"msg":"allocating namespace"}
  {"level":"info","ts":1759792341.882279,"msg":"allocated namespace","nsName":"auxiliary-ac6882"}
  {"level":"info","ts":1759792341.882324,"msg":"label namespace for podReadinessGate injection","nsName":"auxiliary-ac6882"}
  {"level":"info","ts":1759792341.969394,"msg":"labeled namespace with podReadinessGate injection","nsName":"auxiliary-ac6882"}
  STEP: deploying stack @ 10/06/25 16:12:21.969
  {"level":"info","ts":1759792341.969513,"msg":"allocating namespace"}
  {"level":"info","ts":1759792342.146606,"msg":"allocated namespace","nsName":"alb-gateway-e2e-a853da"}
  {"level":"info","ts":1759792342.146626,"msg":"label namespace for podReadinessGate injection","nsName":"alb-gateway-e2e-a853da"}
  {"level":"info","ts":1759792342.237154,"msg":"labeled namespace with podReadinessGate injection","nsName":"alb-gateway-e2e-a853da"}
  {"level":"info","ts":1759792342.23718,"msg":"creating gateway class","gwc":{"name":"gwclass-e2e-alb"}}
  {"level":"info","ts":1759792342.325216,"msg":"creating loadbalancer config","lbc":{"name":"lbconfig-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.412168,"msg":"creating target group config","tgc":{"name":"tgconfig-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.5026371,"msg":"created target group config","tgc":{"name":"tgconfig-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.502692,"msg":"creating listener rule config","lrc":{"name":"lrconfig-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.590423,"msg":"created listener rule config","tgc":{"name":"lrconfig-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.5904481,"msg":"creating deployment","dp":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.678188,"msg":"created deployment","dp":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.67822,"msg":"creating service","svc":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.811182,"msg":"created service","svc":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.811214,"msg":"creating gateway","gw":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.900067,"msg":"creating http route","httpr":{"name":"gateway-e2e-a909c7","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792342.991968,"msg":"creating http route","httpr":{"name":"gateway-e2e-otherns","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792343.080534,"msg":"waiting until deployment becomes ready","dp":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792347.2507288,"msg":"deployment is ready","dp":{"name":"gateway-e2e","namespace":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792589.5055182,"msg":"creating target group config","tgc":{"name":"aux","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792589.5918021,"msg":"created target group config","tgc":{"name":"aux","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792589.5918431,"msg":"creating deployment","dp":{"name":"gateway-e2e","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792589.6803,"msg":"created deployment","dp":{"name":"gateway-e2e","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792589.6803231,"msg":"creating service","svc":{"name":"gateway-e2e","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792589.806754,"msg":"created service","svc":{"name":"gateway-e2e","namespace":"auxiliary-ac6882"}}
  STEP: checking gateway status for lb dns name @ 10/06/25 16:16:29.806
  STEP: querying AWS loadbalancer from the dns name @ 10/06/25 16:16:29.806
  STEP: verifying listener attributes header modification is applied @ 10/06/25 16:16:30.332
  STEP: verifying AWS loadbalancer resources @ 10/06/25 16:16:30.556
  STEP: verifying HTTP load balancer listener @ 10/06/25 16:16:31.211
  STEP: waiting for target group targets to be healthy @ 10/06/25 16:16:31.431
  STEP: waiting until DNS name is available @ 10/06/25 16:16:31.879
  STEP: sending http request to the lb @ 10/06/25 16:16:31.903
  STEP: cross-ns listener should return 503 as no ref grant is available @ 10/06/25 16:16:32.062
  STEP: confirming the route status @ 10/06/25 16:16:32.21
  STEP: deploying ref grant @ 10/06/25 16:16:32.379
  {"level":"info","ts":1759792592.380001,"msg":"About to create ref grant"}
  {"level":"info","ts":1759792592.380013,"msg":"creating ref grant","refg":{"name":"refgrant","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792592.468245,"msg":"created ref grant","refg":{"name":"refgrant","namespace":"auxiliary-ac6882"}}
  STEP: ensuring cross namespace is materialized @ 10/06/25 16:18:32.467
  STEP: sending http request cross namespace service @ 10/06/25 16:18:33.941
  STEP: confirming the http route status after ref grant is materialized @ 10/06/25 16:18:34.099
  STEP: removing ref grant @ 10/06/25 16:18:34.262
  {"level":"info","ts":1759792714.262222,"msg":"About to delete ref grant"}
  {"level":"info","ts":1759792714.262281,"msg":"deleting ref grant","refg":{"name":"refgrant","namespace":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792714.348026,"msg":"deleted ref grant","refg":{"name":"refgrant","namespace":"auxiliary-ac6882"}}
  STEP: cross-ns listener should return 503 as no ref grant is available @ 10/06/25 16:20:34.346
  STEP: confirming the route status @ 10/06/25 16:20:34.699
  {"level":"info","ts":1759792835.5531259,"msg":"deleting namespace","ns":{"name":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792891.8588538,"msg":"deleted namespace","ns":{"name":"alb-gateway-e2e-a853da"}}
  {"level":"info","ts":1759792892.0382268,"msg":"deleting namespace","ns":{"name":"auxiliary-ac6882"}}
  {"level":"info","ts":1759792910.385352,"msg":"deleted namespace","ns":{"name":"auxiliary-ac6882"}}
• [570.859 seconds]

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shraddhabang, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shraddhabang,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shuqz]

/lgtm

[shuqz]

/approved