-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: clarify controller configuration and helm options #4119
base: main
Are you sure you want to change the base?
Conversation
We received feedback about this page, expressing the need to clarify the controller configuration options content and to direct users to the actual supported Helm chart options.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tucktuck9 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @tucktuck9! |
Hi @tucktuck9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/easycla |
@wweiwei-li @M00nF1sh Can we get a final review/approval on this please? |
We received feedback about this page, expressing the need to clarify the controller configuration options content and to direct users to the actual supported Helm chart options.
Issue
N/A
Description
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯