change pod mutator webhook to fail-open #4062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
<n/a>
Description
Change the pod mutator webhook's failurePolicy from Fail to Ignore, thus it became fail-open.
The pod mutator's purpose is to inject a readinessGate thus during a deployment, old pods will be kept alive until new pods registered and became healthy in targetGroups.
Currently the failurePolicy is fail, so under extreme cases where the controller itself is not alive, this could delay the cluster from recovery by preventing critical pods from been created.
Given the podReadinessGate feature don't have impact on the pod's functionality itself, switch failPolicy to "Ignore" make more sense.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯