-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0 #698
Conversation
Welcome @haoranleo! |
Hi @haoranleo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
what about #687 😬 |
Oops didn't notice this PR.. nice we are going to bump client-go!! Do you think it makes sense to bump the protobuf dependency first and then still pin the latest version of protobuf in your PR? I think ultimately we have to update the protobuf version to address that CVE |
your change set is smaller so it definitely makes sense to get that through first - it was just more of a nudge to get some of these deps updated 😅 |
/ok-to-test |
@haoranleo can you run |
Yea I ran |
eaaca0c
to
a67819c
Compare
a67819c
to
b4fe23e
Compare
@micahhausler could you give a stamp? the CI finally passed.. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoranleo, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick #698 [Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0]
Cherry pick #698 [Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0]
What this PR does / why we need it:
Updates google.golang.org/protobuf to v1.33.0 to resolve CVE-2024-24786.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes # CVE-2024-24786