Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm/CSIDriver] Switch to non-deprecated apiVersion #836

Merged
merged 1 commit into from
Apr 20, 2021
Merged

[helm/CSIDriver] Switch to non-deprecated apiVersion #836

merged 1 commit into from
Apr 20, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Apr 18, 2021

Is this a bug fix or adding new feature?
Improvement

What is this PR about? / Why do we need it?
In this commit, we switch CSIDriver resources to the latest stable
apiVersion so to surpass warning messages on deploying and also prepare
chart for future k8s version where storage/v1beta1 will be removed.

What testing is done?
Already deployed this change on k8s cluster v1.18+

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2021
@dntosas dntosas changed the title [helm/csiDriver] Switch to non-deprecated apiVersion [helm/CSIDriver] Switch to non-deprecated apiVersion Apr 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2021
@coveralls
Copy link

coveralls commented Apr 18, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.078%
Totals Coverage Status
Change from base Build 1852: 0.0%
Covered Lines: 1896
Relevant Lines: 2310
💛 - Coveralls

@bertinatto
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 19, 2021
@bertinatto
Copy link
Member

bertinatto commented Apr 19, 2021 •
edited
Loading

The CSIDriver changes:

/lgtm

I'll leave the approve label to AWS folks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021
@AndyXiangLi
Copy link
Contributor

Can you also update kustomization template in the PR as well, thanks!

@dntosas
[helm/csiDriver] Switch to non-deprecated apiVersion
5fc2842 
In this commit, we switch CSIDriver resources to the latest stable
apiVersion so to surpass warning messages on deploying and also prepare
chart for future k8s version where storage/v1beta1 will be removed.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the migrate-to-nonDeprecated-apiVersions branch from 729cf87 to 5fc2842 Compare April 20, 2021 05:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@dntosas
Copy link
Contributor Author

dntosas commented Apr 20, 2021

@AndyXiangLi ready! thnx for pointing out ^^

@dntosas
Copy link
Contributor Author

dntosas commented Apr 20, 2021

/retest

@AndyXiangLi
Copy link
Contributor

/lgtm
/approve
thx!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, dntosas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 621b0e0 into kubernetes-sigs:master Apr 20, 2021
@dntosas dntosas deleted the migrate-to-nonDeprecated-apiVersions branch April 21, 2021 06:53
@wongma7 wongma7 mentioned this pull request Apr 21, 2021
Merged
@wd wd mentioned this pull request May 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@bertinatto bertinatto

@AndyXiangLi AndyXiangLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dntosas @k8s-ci-robot @coveralls @bertinatto @AndyXiangLi