Remove migration go.mod #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 1203
💛 - Coveralls |
wongma7
force-pushed
the
migrationgomod
branch
from
d415a6a to
e2b27c4
Compare
wongma7
force-pushed
the
migrationgomod
branch
from
e2b27c4 to
dcd5ece
Compare
k8s-ci-robot
added
size/XXL
|
/retest 2 io2 tests timed out |
|
@jsafrane ptal this should fix the migration test or at least get it to run again |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? fix (maybe) #560
since the whole repo already has a dependency on k8s.io/kubernetes, it seems unnecessary to have dedicated this go.mod for pulling in the in-tree tests. The test should use the repo's vendored dependency on k8s.io/kubernetes instead of its own go.mod one
What testing is done? None, the periodic job is failing anyway so will need to see if it starts succeeding or at least failing in a different way.