Skip to content

Update makefile #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

Update makefile #373

merged 1 commit into from
Sep 16, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?

  • Update makefile to move go build related environment variables into Dockerfile
  • Make image name configurable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2019
@coveralls
Copy link

coveralls commented Sep 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 851

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.972%
Totals Coverage Status
Change from base Build 849: 0.0%
Covered Lines: 1176
Relevant Lines: 1657
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/retest

1 similar comment
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit ac3a847 into kubernetes-sigs:master Sep 16, 2019
@leakingtapan leakingtapan deleted the makefile branch September 16, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leakingtapan @k8s-ci-robot @coveralls