Update IAM policy for CopyVolumes

[benbz]

What type of PR is this?

/kind documentation

What is this PR about? / Why do we need it?

#2716 added volume cloning functionality and updated the IAM policy in various places. It unfortunately omitted docs/example-iam-policy.json.

When comparing hack/e2e/kops/patch-cluster.yaml and docs/install.md it was also noticed that one of the Actions was incorrect in docs/install.md and should have been ec2:CreateTags

How was this change tested?

n/a

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: benbz / name: Ben Banfield-Zanin (975ce26)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @benbz!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @benbz. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ConnorJC3]

Hi @benbz - that's intentional for the moment. We keep the example policy in sync with the AWS managed policy to reduce confusion and avoid issues with switching between the policies.

After the managed policy is updated, the example policy will also be updated with CopyVolumes permissions. In the meantime, if you need an example of how to add CopyVolumes to your policy, you can see the installation guide which includes a section on CopyVolumes permissions (I'll make sure to get the typo of CreateTags fixed there, good catch).

[benbz]

Ack, thanks for the heads up @ConnorJC3 . I can understand that rationale.

I'm currently working through the CLA process for my company. Is it worth me keeping this PR open or will you open something separate when you have time? Should I split out the CreateTags fix to a separate PR?

[ConnorJC3]

If you want to split out the CreateTags request that'd be great as we can merge that right away (or well once you get the CLA figured out as that's a k8s project requirement). Either that or I can split it out if you don't want, either works.