Add helm-tester enabled flag

[nunodomingues-td]

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
Adding a flag to enable / disable test during pipeline when using chart-testing

What testing is done?
Manual / pipeline tests

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: nunodomingues-td (651e6aa, 4230a8e, 498a628)

[k8s-ci-robot]

Welcome @nunodomingues-td!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @nunodomingues-td. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ConnorJC3]

Hi @nunodomingues-td , running tests to confirm driver behavior during our ct checks is intentional behavior that we do not want to disable.

When installing the driver with helm install the tests should not be installed. If you need to disable the tests when rendering manifests, you can use --skip-tests as documented by @torredil here: #1535 (comment)

[nunodomingues-td]

Hello @ConnorJC3

Thanks for your reply, but my issue is not that simple.

At my company we don't install helm chart manually, we're deploying them using a few pipelines and then using a GitOps CD tool to deploy them.

In our pipelines, we have a few tests, and one of them use CT for rendering, testing, and install (dry-run) the helm charts. Our pipelines are being executed and our charts are being deployed (most of them) in graviton instances, which brings me to a few issues:

• We don't want to execute tests again in our pipeline when using third party charts ( we build our own charts and build our tests), because we're assuming that the tests are being executed before the releases are created
• The test is using a intel/amd based image and the node selector is kubernetes.io/arch: amd64

That's why the reason of this PR. All of this to explain that your solution does not work for us and we kindly ask for a review in this.

If you still don't want to move forward, can you give us a even better solution that we can use?

Thanks and best regards

[AndrewSirenko]

/ok-to-test

[github-actions]

Code Coverage Diff

This PR does not change the code coverage

[ConnorJC3]

/label tide/merge-method-squash
/lgtm

@nunodomingues-td this looks good go to me, one small thing:

There was a vulnerability in one of our dependencies that was fixed in #1959, you'll need to rebase your PR on top of the latest master branch to get govulncheck to pass.

[nunodomingues-td]

/label tide/merge-method-squash /lgtm

@nunodomingues-td this looks good go to me, one small thing:

There was a vulnerability in one of our dependencies that was fixed in #1959, you'll need to rebase your PR on top of the latest master branch to get govulncheck to pass.

Hello @ConnorJC3
My branch is now rebased. Thanks for the warning

[nunodomingues-td]

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andrewsirenko. For more information see the Kubernetes Code Review Process.

@AndrewSirenko 🙏

[AndrewSirenko]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AndrewSirenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment