Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change modifyVolumeRequestHandlerTimeout to a configurable option #1915

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Change modifyVolumeRequestHandlerTimeout to a configurable option #1915

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
282e868
Change modifyVolumeRequestHandlerTimeout to a configurable option
andrewcharlton Jan 30, 2024
c968e0d
Fix zero timeout being passed to driver in non-controller modes
andrewcharlton Jan 31, 2024
d3e650a
Add docs about resizer and volumemodifier timeouts
andrewcharlton Feb 1, 2024
ea11623
Add additional test for the controller options
andrewcharlton Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add additional test for the controller options
  • Loading branch information
@andrewcharlton
andrewcharlton committed Feb 1, 2024
commit ea11623555e497dc6965ad6e65f0b1ab53fab1af
5 changes: 5 additions & 0 deletions cmd/options/controller_options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ func TestControllerOptions(t *testing.T) {
flag: "user-agent-extra",
found: true,
},
{
name: "lookup modify-volume-request-handler-timeout",
flag: "modify-volume-request-handler-timeout",
found: true,
},
{
name: "fail for non-desired flag",
flag: "some-other-flag",
Expand Down
Loading