Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend resource list in Kustomization file #1634

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

torredil
Copy link
Member

What is this PR about? / Why do we need it?

This PR expands the resource list in our Kustomization file. It adds the role and rolebinding resource for leases and ensures they're created in the correct namespace, kube-system.

What testing is done?

Without this patch:

kubectl get roles --all-namespaces                                                                                                                                                                       
NAMESPACE     NAME                                             CREATED AT
kube-public   system:controller:bootstrap-signer               2023-06-16T14:15:38Z
kube-system   extension-apiserver-authentication-reader        2023-06-16T14:15:37Z
kube-system   kops-controller                                  2023-06-16T14:15:42Z
kube-system   system::leader-locking-kube-controller-manager   2023-06-16T14:15:38Z
kube-system   system::leader-locking-kube-scheduler            2023-06-16T14:15:38Z
kube-system   system::leader-locking-migration                 2023-06-16T14:15:44Z
kube-system   system:controller:bootstrap-signer               2023-06-16T14:15:37Z
kube-system   system:controller:cloud-provider                 2023-06-16T14:15:37Z
kube-system   system:controller:token-cleaner                  2023-06-16T14:15:37Z

With this patch:

kubectl get roles --all-namespaces                                                                                                                                                                          
NAMESPACE     NAME                                             CREATED AT
kube-public   system:controller:bootstrap-signer               2023-06-16T14:15:38Z
kube-system   ebs-csi-leases-role                              2023-06-16T14:22:09Z
kube-system   extension-apiserver-authentication-reader        2023-06-16T14:15:37Z
kube-system   kops-controller                                  2023-06-16T14:15:42Z
kube-system   system::leader-locking-kube-controller-manager   2023-06-16T14:15:38Z
kube-system   system::leader-locking-kube-scheduler            2023-06-16T14:15:38Z
kube-system   system::leader-locking-migration                 2023-06-16T14:15:44Z
kube-system   system:controller:bootstrap-signer               2023-06-16T14:15:37Z
kube-system   system:controller:cloud-provider                 2023-06-16T14:15:37Z
kube-system   system:controller:token-cleaner                  2023-06-16T14:15:37Z

kubectl get rolebinding --all-namespaces                                                                                                                                                                
NAMESPACE     NAME                                                       ROLE                                                  AGE
kube-public   system:controller:bootstrap-signer                         Role/system:controller:bootstrap-signer               8m27s
kube-system   cloud-controller-manager:apiserver-authentication-reader   Role/extension-apiserver-authentication-reader        8m18s
kube-system   ebs-csi-leases-rolebinding                                 Role/ebs-csi-leases-role                              116s
...

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from ConnorJC3 and gtxu June 16, 2023 14:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2023
@torredil torredil requested a review from hanyuel June 16, 2023 14:29
@torredil torredil marked this pull request as ready for review June 16, 2023 14:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from rdpsin June 16, 2023 14:29
@ConnorJC3
Copy link
Contributor

Manually validated:

$ kubectl apply -k deploy/kubernetes/overlays/stable/ecr-public                   
serviceaccount/ebs-csi-controller-sa created
serviceaccount/ebs-csi-node-sa created
clusterrole.rbac.authorization.k8s.io/ebs-csi-node-role created
...

$ kubectl apply -f examples/kubernetes/dynamic-provisioning/manifests 
persistentvolumeclaim/ebs-claim created
pod/app created
storageclass.storage.k8s.io/ebs-sc created

$ kubectl get pvc
NAME        STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
ebs-claim   Bound    pvc-f2cbb4f2-b7b5-442b-b83c-921153101f48   4Gi        RWO            ebs-sc         6s

$ kubectl get pods
NAME   READY   STATUS    RESTARTS   AGE
app    1/1     Running   0          23s

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@ConnorJC3
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

@torredil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows c4e4ff5 link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87edcf9 into kubernetes-sigs:master Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants