-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logline to remove "formatted" #1612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also make this change in #241? If the disk is already formatted or it is being mounted as read-only, it will be mounted without formatting.
suggest: NodeStageVolume: staging volume
Looks great, one last request before merging this change; lets squash the commits: https://kubernetes.io/docs/contribute/new-content/open-a-pr/#squashing-commits |
This code path is always hit when mounting, even when the filesystem was already present, and we just mount it. Reading these log lines for existing PVCs makes my heart miss a beat, when I realize that the volume was indeed not formatted before mounting. If its being formatted, its already present in logs above when on v=4. Signed-off-by: Odin Ugedal <odin@uged.al>
Thanks for the suggestion @torredil! Rebased and pushed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@odinuge Thank you for your contribution 👍
/test pull-aws-ebs-csi-driver-external-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Just updating a logline.
What is this PR about? / Why do we need it?
This code path is always hit when mounting, even when the filesystem was already present, and we just mount it.
Reading these log lines for existing PVCs makes my heart miss a beat, when I realize that the volume was indeed not formatted before mounting. If its being formatted, its already present in logs above when on v=4.
What testing is done?
n/a