-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support interpolated snapshot tags #1558
Support interpolated snapshot tags #1558
Conversation
Hi @hanyuel. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
247e8a6
to
71b2d92
Compare
Waiting for #1560 to land, fixes |
/lgtm |
/hold will let the PR author unhold when everything is good to go. |
71b2d92
to
ab5e5f9
Compare
/lgtm |
ab5e5f9
to
c9caeae
Compare
c9caeae
to
6a4934e
Compare
/unhold |
Waiting for #1560 before we can merge this. |
/retest |
1 similar comment
/retest |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gtxu, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
New feature.
What is this PR about? / Why do we need it?
For more details, see issue #1553
VolumeSnapshot
name, namespace andVolumeSnapshotContent
name.controller.yaml
to allow setting--extra-create-metadata
forcsi-snapshotter
sidecar. It enablesexternal-snapshotter
to pass the snapshot parameters to CSI Driver.What testing is done?
and this VolumeSnapshot
The tags for the snapshot in the AWS EC2 console were created as expected: