Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Windows container for Windows Server 2022 LTSC #1408

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Build Windows container for Windows Server 2022 LTSC #1408

merged 1 commit into from
Oct 3, 2022

Conversation

ConnorJC3
Copy link
Contributor

Signed-off-by: Connor Catlett conncatl@amazon.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2022
@ConnorJC3
Build Windows container for Windows Server 2022 LTSC
4231cd0 
Signed-off-by: Connor Catlett <conncatl@amazon.com>
@torredil torredil requested review from gtxu and torredil and removed request for bertinatto and AndyXiangLi September 29, 2022 22:51
torredil
torredil approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorJC3 ConnorJC3 mentioned this pull request Oct 3, 2022
Closed
@gtxu
Copy link
Contributor

gtxu commented Oct 3, 2022

/lgtm

@torredil
Copy link
Member

torredil commented Oct 3, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 74ab96e into kubernetes-sigs:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@gtxu gtxu

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @k8s-ci-robot @gtxu @torredil