Add unit test for node service

[leakingtapan]

Is your feature request related to a problem?/Why is this needed
Add unit test for node service

• NodeStageVolume
• NodeUnStageVolume
• NodePublishVolume
• NodeUnpublishVolume
• MountOpetion support
• NodeStageVolume Idempotency

[bertinatto]

/assign

I've been thinking about this, so I'll take a stab at it.

[leakingtapan]

To share some ideas in my mind, we can define the driver's mounter definition here using the mounter.Interface interface instead of mount.SafeFormatAndMount struct. Since it actual implements the interface here. With that, we can easily create mocks using gomock and mock it out inside of out unit tests.

Hope this aligns with what you are thinking

[bertinatto]

FormatAndMount is only implemented in mount.SafeFormatAndMount, so unless we drop it we need this type.

My idea was to use a file as a block device; and use it as a target device in the Node* calls. It might require root privileges, but it's more realistic.

[leakingtapan]

FormatAndMount is a simple wrapper around mounter.Interface.Mount(source, target, fstype, options)

[bertinatto]

From what I see, SafeFormatAndMount.FormatAndMount() is a wrapper around SafeFormattAndMount.formatAndMount, that in turn has a lot of logic in it.

[leakingtapan]

You are right, didn't look at the right file...

[leakingtapan]

Given that, make FormatAndMount being an interface that SafeFormatAndMount implements make more sense to me, the change will be in upstream which requires extra work. But this could benefit unit testing of other drivers which makes me think worth it.

I feel we can do something like:

type SafeFormatAndMount struct {
    Interface
    Exec
    Formatter
}

type Formatter interface {
    FormatAndMount(source string, target string, fstype string, options []string) error
}

How do you think? Also running unit test with sudo is a bit over killing

[leakingtapan]

/assign @sreis

[k8s-ci-robot]

@leakingtapan: GitHub didn't allow me to assign the following users: sreis.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sreis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.