Add deprecation warnings for --extra-volume-tags flag

kubernetes-sigs · Oct 2, 2020 · 7a33d85 · 7a33d85
1 parent 9b99308
commit 7a33d85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/cmd/options/controller_options.go b/cmd/options/controller_options.go
@@ -29,6 +29,7 @@ type ControllerOptions struct {
 	ExtraTags map[string]string
 	// ExtraVolumeTags is a map of tags that will be attached to each dynamically provisioned
 	// volume.
+	// DEPRECATED: Use ExtraTags instead.
 	ExtraVolumeTags map[string]string
 	// ID of the kubernetes cluster.
 	KubernetesClusterID string

diff --git a/pkg/driver/driver.go b/pkg/driver/driver.go
@@ -154,7 +154,8 @@ func WithExtraTags(extraTags map[string]string) func(*DriverOptions) {
 
 func WithExtraVolumeTags(extraVolumeTags map[string]string) func(*DriverOptions) {
 	return func(o *DriverOptions) {
-		if o.extraTags == nil {
+		if o.extraTags == nil && extraVolumeTags != nil {
+			klog.Warning("DEPRECATION WARNING: --extra-volume-tags is deprecated, please use --extra-tags instead")
 			o.extraTags = extraVolumeTags
 		}
 	}