Skip to content

Conversation

nan-yu
Copy link
Contributor

@nan-yu nan-yu commented Apr 22, 2020

The test is to guarantee that existing application CR objects also work with new Application CRD and controller.
The old_app_crd.yaml was from version v0.8.0, which was released before we migrated to kubebuild 2.x.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2020
@nan-yu nan-yu requested review from barney-s and janetkuo April 22, 2020 00:56
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nan-yu
To complete the pull request process, please assign barney-s
You can assign the PR to them by writing /assign @barney-s in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@barney-s barney-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments.

The test is to guarantee that existing application CR objects also work
with new Application CRD and controller.
@barney-s
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2020
@nan-yu nan-yu merged commit dacfd2a into kubernetes-sigs:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants