Skip to content

Conversation

@jkh52
Copy link
Contributor

@jkh52 jkh52 commented Oct 6, 2024

Help unblock dependabot and enable the 0.31 release.

$ go get github.com/prometheus/client_golang@v1.20.4
$ go mod tidy
$ go mod vendor

Fix test fallout.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2024
@jkh52
Copy link
Contributor Author

jkh52 commented Oct 6, 2024

/assign @cheftako

@jkh52 jkh52 changed the title Upgrade client_golang to help unblock dependabot. Upgrade github.com/prometheus/client_golang to help unblock dependabot. Oct 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@jkh52 jkh52 force-pushed the test-nil-metrics branch from 122d7ad to 7b3f04c Compare October 7, 2024 03:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@cheftako
Copy link
Contributor

/test pull-apiserver-network-proxy-make-lint-master

@cheftako
Copy link
Contributor

Rerunning lint to see if the new kubekins image has helped with the lint error.

@cheftako
Copy link
Contributor

/test pull-apiserver-network-proxy-make-lint-master

@k8s-ci-robot
Copy link
Contributor

@jkh52: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-apiserver-network-proxy-make-lint-master 7b3f04c link true /test pull-apiserver-network-proxy-make-lint-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bwplotka
Copy link

FYI: We reverted the problematic change in https://github.com/prometheus/client_golang/releases/tag/v1.20.5, sorry for pain!

@jkh52
Copy link
Contributor Author

jkh52 commented Oct 15, 2024

FYI: We reverted the problematic change in https://github.com/prometheus/client_golang/releases/tag/v1.20.5, sorry for pain!

Thanks for the heads up! I verified that v1.20.5 resolves our dependabot issue. I will close this workaround PR.

@jkh52 jkh52 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants