Skip to content

test: fix race condition #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Mar 30, 2023

Fixes the race condition when running the test

client_test.go:134: client.endpointConn not released
E0330 19:34:12.841766   16710 client.go:489] "could not send DIAL_RSP" err="expected send error" dialID=111 connectionID=1 dialAddress="127.0.0.1:57901"
E0330 19:34:12.842510   16710 client.go:440] "close response failure" err="expected send error" ="(MISSING)"
E0330 19:34:16.834985   16710 client.go:388] "could not read stream" err="timeout recv" serverID="" agentID=""
E0330 19:34:16.838832   16710 client.go:388] "could not read stream" err="timeout recv" serverID="" agentID=""
E0330 19:34:16.839057   16710 client.go:388] "could not read stream" err="timeout recv" serverID="" agentID=""
E0330 19:34:17.842124   16710 client.go:388] "could not read stream" err="timeout recv" serverID="" agentID=""
FAIL
FAIL	sigs.k8s.io/apiserver-network-proxy/pkg/agent	8.111s
?   	sigs.k8s.io/apiserver-network-proxy/pkg/agent/metrics	[no test files]
FAIL

Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ipochi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 30, 2023
@cheftako
Copy link
Contributor

cheftako commented Apr 3, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2023
@cheftako
Copy link
Contributor

cheftako commented Apr 3, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, ipochi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 76fb285 into kubernetes-sigs:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants