-
Notifications
You must be signed in to change notification settings - Fork 385
Update minikube start docs #2365
Update minikube start docs #2365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
/lgtm |
docs/install.md
Outdated
|
||
```console | ||
minikube start --extra-config=apiserver.Authorization.Mode=RBAC | ||
minikube start ----bootstrapper=kubeadm --extra-config=apiserver.authorization-mode=RBAC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to kubernetes/minikube#1722 (comment) minikube enables RBAC by default as of v0.26.0
Additionally, my read on this for syntax: If you are using minikube versions v25.2 or older you need to use the old syntax --extra-config=apiserver.Authorization.Mode=RBAC but if you are using newer version (ie V26.0 or newer), you need to specify --extra-config=apiserver.authorization-mode=RBAC. OR don't specify extra config at all. Those details from kubernetes/minikube#2798 (comment)
I'd rework this to say:
if using Minikube v0.25 or older, you must specify
minikube start --extra-config=apiserver.Authorization.Mode=RBAC
If using v0.26 or newer, do not specify extra-config. Using "--extra-config=apiserver.Authorization.Mode" in v0.26 or greater may result in a hang as the flag has been changed to --extra-config=apiserver.authorization-mode and the default is to use RBAC. Start minikube with
minikube start
I believe these details are accurate, I'd prefer to specify specific versions and remove the word "you may not need to specify" from the text immediately following this. :)
@jboyd01 I've update the PR to incorporate your clarification around |
Thanks for fixing @carolynvs! |
@jboyd01 Can you slap on a |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs/install.md
Outdated
|
||
With Minikube v0.26+, do not specify `--extra-config`. The | ||
flag has since been changed to `--extra-config=apiserver.authorization-mode` and | ||
the Minikube now uses RBAC by default. Specifying the older flag may cause the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Minikube -> Minikube
* Update minikube start docs * Clarify when to use the extra-config flag * nit - the Minikube -> Minikube
This PR is a
What this PR does / why we need it:
Updates our doc to match breaking changes in minikube.
Preview available at: https://deploy-preview-2365--svc-cat.netlify.com/docs/install/#minikube
Which issue(s) this PR fixes
Fixes #2325
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update