Replace forked KubernetesNamespaceLifecycle admission plugin with k8s.io/apiserver one #2258
Conversation
k8s-ci-robot
added
size/L
| @@ -39,7 +39,7 @@ spec: | |||
| - {{ .Values.apiserver.audit.logPath }} | |||
| {{- end}} | |||
| - --enable-admission-plugins | |||
| - "KubernetesNamespaceLifecycle,DefaultServicePlan,ServiceBindingsLifecycle,ServicePlanChangeValidator,BrokerAuthSarCheck" | |||
| - "NamespaceLifecycle,DefaultServicePlan,ServiceBindingsLifecycle,ServicePlanChangeValidator,BrokerAuthSarCheck" | |||
There was a problem hiding this comment.
This now refers to a k8s.io/apiserver version (see https://github.com/kubernetes/apiserver/blob/master/pkg/admission/plugin/namespace/lifecycle/admission.go), which gets automatically registered in https://github.com/kubernetes/apiserver/blob/master/pkg/server/plugins.go#L30
There was a problem hiding this comment.
To double check, I simply made this change against the current release of Service Catalog running in my cluster, and it worked with no issues.
….io/apiserver one
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyrickard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixes #2255
Since
NamespaceLifecyclenow exists ink8s.io/apiserver, there is no need to host a forked copy (which is currently outdated) anymore.