This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Revert "NFS plugin does not support ControllerServiceCapability" #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xing-yang @rootfs Corresponding fixes to external-provisioner and external-attacher have already been merged. We just need to push new images to quay.io |
|
@sbezverk Ok, thanks. |
|
@xing-yang I just pushed the latest images, could you please try your PR which eliminates controller part? |
|
@sbezverk Will do. |
|
Ok. Tested with the latest attacher image along with this nfsplugin image in my repo xyang105/csi:csi-nfsplugin3. It works now. No need to revert. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #62
ControllerService is still needed because the attacher still checks it.