Rewrite addon-resizer nanny #2623
Conversation
Before this change, flag value was being read before call to Parse(), which resulted in default value being used instead of command line argument.
There will be a single estimator class, providing two ranges: acceptable and recommended range. As long as current pod requirements and limits fall into acceptable range, nothing happens. Once either limits or requirements fall out of acceptable range, they are both updated to lower (when upscaling) or higher (when downscaling) end of recommended range. This approach prevents flapping, which took place in previous implementation, when cluster size oscillated around certain values.
|
This change is |
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
/assign @mwielgus |
|
(Ping robot for CLA refresh.) |
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: x13n Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
|
Please migrate this PR to kubernetes/autoscaler |
|
Done: kubernetes/autoscaler#128, closing this. |
Automatic merge from submit-queue (batch tested with PRs 46850, 47984) Update addon-resizer version Update addon-resizer version and remove the flags that have been deprecated in the new version. **What this PR does / why we need it**: ref kubernetes-retired/contrib#2623 **Special notes for your reviewer**: Need to wait for merging kubernetes-retired/contrib#2623 first. **Release note**: ```release-note addon-resizer flapping behavior was removed. ```
There will be a single estimator class, providing two ranges: acceptable
and recommended range. As long as current pod requirements and limits fall into
acceptable range, nothing happens. Once either limits or requirements
fall out of acceptable range, they are both updated to lower (when
upscaling) or higher (when downscaling) end of recommended range. This
approach prevents flapping, which took place in previous implementation,
when cluster size oscillated around certain values.
More details: https://docs.google.com/a/google.com/document/d/1T0A7GHwNU_w6gpq_eCN166aRth6usbRvxgJJqSZeESU/edit?usp=sharing (shared with kubernetes-sig-instrumentation and kubernetes-sig-autoscaling)