Grant Bucket Access [WIP] #54
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YiannisGkoufas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @YiannisGkoufas. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@YiannisGkoufas: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| if err != nil { | ||
| errChan <- err | ||
| } | ||
| _, err = cl.BucketExists(ctx, uuid.New().String()) |
There was a problem hiding this comment.
adminClient, err := madmin.New(host.Host, accessKey, secretKey, secure)
if err != nil {
errChan <- errors.Wrap(err, "Creating an admin client failed")
return
}
| Secure: secure, | ||
| }) | ||
| if err != nil { | ||
| errChan <- err |
There was a problem hiding this comment.
errChan <- errors.Wrap(err, "Creating an MinIO client failed")
return
| errChan <- err | ||
| } | ||
| _, err = cl.BucketExists(ctx, uuid.New().String()) | ||
| _, err = client.BucketExists(ctx, uuid.New().String()) |
There was a problem hiding this comment.
check both regular client and admin client here
There was a problem hiding this comment.
for the admin client, call ServerInfo and check that err is nil
k8s-ci-robot
added
the
needs-rebase
|
@YiannisGkoufas: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing it to move WIP in https://github.com/kubernetes-sigs/cosi-driver-minio.git |
3 participants
Take on #51