-
Notifications
You must be signed in to change notification settings - Fork 30
Adding minio-driver #11
Conversation
|
Welcome @sajanjswl! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sajanjswl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sajan Jaiswal <sjnjaiswal@gmail.com>
|
Part of #8 |
|
/closes #5 |
| } | ||
|
|
||
| func (ds DriverServer) ProvisionerCreateBucket(ctx context.Context, req *cosi.ProvisionerCreateBucketRequest) (*cosi.ProvisionerCreateBucketResponse, error) { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is empty?
|
I dont like the idea of having an entirely different go dependency tree for a proejct under the same root. Let's discuss how to simplify this. cc @rrati |
|
@wlan0 Agreed. It was always intended to pull the example provisioner into the main build structure, we just didn't get there before the move. This seems like a perfect time to correct that and not put the sample provisioner in its own tree. |
|
@sajanjswl: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close Done as part of #27 |
Signed-off-by: Sajan Jaiswal sjnjaiswal@gmail.com