This repository was archived by the owner on Aug 12, 2025. It is now read-only.
better binary management for genkgo #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
reviewed
May 28, 2020
test/e2e/Makefile
Outdated
|
|
||
| ginkgo: $(GINKGO) | ||
| $(GINKGO): $(TOOLS_DIR)/go.mod # Build kustomize from tools folder. | ||
| cd $(TOOLS_DIR) && go build -tags=tools -o $(BIN_DIR)/ginkgo github.com/onsi/ginkgo/ginkgo |
There was a problem hiding this comment.
Something is inconsistent here. It checks if $(GINKGO) exists, which resolves to $(TOOLS_BIN_DIR)/ginkgo, which resolves to $(TOOLS_DIR)/$(BIN_DIR)/ginkgo, which resolves to $(REPO_ROOT)/hack/tools/bin/ginkgo, but then you are building it to -o $(BIN_DIR)/ginkgo, which is just ./bin/ginkgo. I think you wanted to target the actual $(GINKGO)?
It might be easier to just do
go build -o $@ github.com/onsi/ginkgo/ginkgo
deitch
approved these changes
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.