This repository was archived by the owner on Aug 12, 2025. It is now read-only.
cluster-template-development #778
Merged
+397
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
displague
reviewed
Jun 27, 2024
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
…bject order Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
…ent.yaml Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
cprivitere
force-pushed
the
cprivitere/issue767
branch
from
1f44633 to
d954ed0
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Fixes #767 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com
What this PR does / why we need it:
Create a new cluster-template-development.yaml file to help folks following the docker clusterctl quickstart directions avoid an error. File is just a copy of cluster-template.yaml. But it is fully generated and has its own kustomize directory so we can add customizations to it in the future if we decide we want to.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #767