this PR uses buildx to update manifest for the new release #65
Conversation
.github/workflows/release.yaml
Outdated
| - name: "Unshallow (required by goreleaser)" | ||
| run: git fetch --prune --unshallow | ||
| - name: Get the version | ||
| run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//} |
There was a problem hiding this comment.
I don't see is consuming this anywhere; why do we set it?
There was a problem hiding this comment.
It used at the end of the file to build the manifest
There was a problem hiding this comment.
Then I think you need to do ::set-env and not ::set-output
| - name: manifest-debug | ||
| run: make manifest | ||
| - name: find-debug | ||
| run: find ./out |
There was a problem hiding this comment.
Heh, nice to see the debug going away, now that you fixed it.
| - name: find-debug | ||
| run: find ./out | ||
| - name: Set up Docker Buildx | ||
| uses: crazy-max/ghaction-docker-buildx@v1 |
There was a problem hiding this comment.
I am a little concerned about putting an action from some unknown person in our supply chain. Is there a more standardized way to get it? A docker/* action or GitHub actions/* action?
There was a problem hiding this comment.
crazy-max is the same person that maintains the goreleaser one, but I understand your concerns. I took it from the GitHub marketplace, I will look for something different if exists
There was a problem hiding this comment.
It is worth a 5-10 min search to see if anything from a corporate source is available. If not, we can live with it. I expect eventually the docker actions will have it built-in
| run: | | ||
| buildx imagetools create \ | ||
| -t packethost/cluster-api-provider-packet:v0.3.0 \ | ||
| packethost/cluster-api-provider-packet:$VERSION-amd64 \ |
There was a problem hiding this comment.
Is this building the multi-arch manifest? Could we capture this? We now have the version hard-coded in here, and the specific architectures hard-coded in here.
There was a problem hiding this comment.
ehehe it is my error the VERSION env var I set above and you said was not used should be used here :D
There was a problem hiding this comment.
Can we remove the list of architectures, generate it somehow, so that we don't have it hard-coded here and in Makefile and in multiple yaml, and...
There was a problem hiding this comment.
As we spoke on Slack, I am not 100% sure about how to do it effectively but I share your same concerns in terms of having configuration duplicated across many tools: makefile, github actions and goreleaser. but I will try to fix it later
2 participants
No description provided.