Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

🐛 Fix patchErr not being checked in packetmachine_controller #624

Merged
merged 1 commit into from
Aug 14, 2023
Merged

🐛 Fix patchErr not being checked in packetmachine_controller #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/packetmachine_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s
// Avoid a flickering condition between InstanceProvisionStarted and InstanceProvisionFailed if there's a persistent failure with createInstance
if conditions.GetReason(machineScope.PacketMachine, infrav1.DeviceReadyCondition) != infrav1.InstanceProvisionFailedReason {
conditions.MarkFalse(machineScope.PacketMachine, infrav1.DeviceReadyCondition, infrav1.InstanceProvisionStartedReason, clusterv1.ConditionSeverityInfo, "")
if patchErr := machineScope.PatchObject(ctx); err != nil {
if patchErr := machineScope.PatchObject(ctx); patchErr != nil {
log.Error(patchErr, "failed to patch conditions")
return ctrl.Result{}, patchErr
}
Expand Down