Updated component-base/logs instead of old logging style

[codinja1188]

What this PR does / why we need it:
Updated component-base/logs instead of old logging style.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #546

[k8s-ci-robot]

Welcome @Vasubabu!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-packet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-packet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[cprivitere]

You'll want to try compiling this locally first before pushing. There's definitely an extra definition of pflag here and I imagine a make generate needs to be run too.

[cprivitere]

Do you know why we don't need the _ "k8s.io/component-base/logs/json/register" line they had in the original code suggestion?

Also, can we call this something other than v1. I'd prefer something like logsv1.

[codinja1188]

updated

[cprivitere]

For reference, here's the upstream change that started normalizing flag input: sbueringer/cluster-api@21740cb

Seems like a good thing to do.

[cprivitere]

Change line 106 from

	ctrl.SetLogger(klogr.New())

to

	// klog.Background will automatically use the right logger.
	ctrl.SetLogger(klog.Background())

This is per another upstream change that they got in later.

[cprivitere]

/approve

[cprivitere]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, vasubabu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cprivitere]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment