This repository was archived by the owner on Aug 12, 2025. It is now read-only.
Fix REGISTRY CI variable in release.yaml #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
displague
reviewed
May 2, 2023
| env: | ||
| TAG: ${{ needs.build-image.outputs.image-tag }} | ||
| REGISTRY: ${{ env.QUAY_REGISTRY }} | ||
| REGISTRY: quay.io/${{ secrets.QUAY_ORG }} |
There was a problem hiding this comment.
While unintuitive, this is how it is defined:
https://github.com/kubernetes-sigs/cluster-api-provider-packet/blob/f7cbb219a2b1c996510f120585523255b9005b85/.github/workflows/ci.yaml#LL16C1-L16C1
displague
approved these changes
May 2, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cprivitere, displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This fixes the REGISTRY env variable in the release.yaml. The last change was invalid as you can't reference previous env variables inside of the env: section.