Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@cprivitere
Copy link
Contributor

@cprivitere cprivitere commented May 1, 2023

What this PR does / why we need it: The 0.7.0 release used ghcr.io as the default registry to publish to. However that registry is currently not public. This patch to the release workflow uses quay.io as the default registry. A separate PR has been made to kubernetes-sigs to make the ghcr.io registry public.

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from detiber and displague May 1, 2023 20:22
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2023
Copy link
Contributor

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the REGISTRY env to the release task should ensure that the release manifest files and release notes refer users to the quay registry, as intended by the PR description.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cprivitere,displague]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@displague
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7cbb21 into kubernetes-retired:main May 1, 2023
@cprivitere cprivitere deleted the use_quay_registry branch May 1, 2023 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants