Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

🏃 Adopt metal-go #527

Merged
merged 2 commits into from
Aug 3, 2023
Merged

🏃 Adopt metal-go #527

merged 2 commits into from
Aug 3, 2023

Conversation

@ctreatma
Copy link
Contributor

What this PR does / why we need it:

This PR replaces packngo with metal-go for all interactions with the Equinix Metal API. The metal-go SDK is generated from the Equinix Metal API spec, and we will gradually replace all usage of packngo with metal-go to streamline support.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @ctreatma!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-packet 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-packet has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2023
@ctreatma ctreatma mentioned this pull request Mar 22, 2023
Merged
ctreatma
ctreatma commented Mar 22, 2023
View reviewed changes
ctreatma
ctreatma commented Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
displague
displague reviewed Mar 22, 2023
View reviewed changes
ctreatma
ctreatma commented Mar 23, 2023
View reviewed changes
ctreatma
ctreatma commented Mar 23, 2023
View reviewed changes
@ctreatma
Copy link
Contributor Author

ctreatma commented Mar 24, 2023 •
edited
Loading

With the latest metal-go that includes the facility input fix, I'm able to run at least part of make test-e2e-local successfully ("part of" because that task runs a long time and I'm on vacation as of a little bit ago).

As of August 2, 2023 I ran the full make test-e2e-local task successfully.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 9, 2023
ctreatma
ctreatma commented May 2, 2023
View reviewed changes
@ctreatma ctreatma marked this pull request as ready for review May 2, 2023 19:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
@k8s-ci-robot k8s-ci-robot requested a review from displague May 2, 2023 19:01
@ctreatma ctreatma changed the title 🏃 [WIP] Adopt metal-go 🏃 Adopt metal-go May 2, 2023
cprivitere
cprivitere reviewed May 4, 2023
View reviewed changes
@displague displague mentioned this pull request May 25, 2023
Closed
@displague displague mentioned this pull request May 26, 2023
Closed
7 tasks
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 2, 2023
@cprivitere
Copy link
Contributor

/hold Setting a hold to be sure we don't commit before all conversations are resolved.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@ctreatma
Switch from packngo to metal-go
94f8872 
This updates CAPP to use metal-go for all Equinix Metal API interactions.
Since metal-go does not support the `PACKNGO_DEBUG` environment variable
for debugging, that behavior is introduced within CAPP for backwards
compatibility.
@ctreatma
Copy link
Contributor Author

ctreatma commented Jun 26, 2023 •
edited
Loading

I believe all of the blocker issues on this PR have been addressed, however I want to get out a metal-go release that replicates the sunset/deprecation header logging and upgrade this PR to use that before this gets merged. (Also, other issues may be identified in this PR as y'all go through it again.)

As of August 2, 2023 this PR has been updated to a version of metal-go that logs Sunset and Deprecation headers.

@cprivitere
Copy link
Contributor

@displague just waiting for you to confirm your conversations are resolved.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctreatma, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@cprivitere
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@cprivitere
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit e9c2ee0 into kubernetes-retired:main Aug 3, 2023
This was referenced Aug 4, 2023
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@detiber detiber Awaiting requested review from detiber

@jacobsmith928 jacobsmith928 Awaiting requested review from jacobsmith928

2 more reviewers

@cprivitere cprivitere cprivitere left review comments

@displague displague displague approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cprivitere cprivitere

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ctreatma @k8s-ci-robot @cprivitere @displague