Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@deitch
Copy link
Contributor

@deitch deitch commented May 14, 2020

I do not know why, but applying this without these fields causes it to fail. Since it is auto-generated, it doesn't hurt.

@deitch deitch requested a review from gianarb May 14, 2020 09:43
@gianarb
Copy link
Contributor

gianarb commented May 14, 2020

Yeah it is part of #49 as well

@deitch
Copy link
Contributor Author

deitch commented May 14, 2020

Ah, I didn't realize you had it. I stumbled across it when testing #51 and thought it just got missed.

When we get #49 in, we can close this.

@gianarb gianarb closed this May 14, 2020
@deitch
Copy link
Contributor Author

deitch commented May 14, 2020

@gianarb these were not added in #49

@deitch deitch reopened this May 14, 2020
@gianarb
Copy link
Contributor

gianarb commented May 14, 2020

o.O I dreamed about it

@gianarb gianarb merged commit 5665cb7 into v1alpha3 May 14, 2020
@deitch deitch deleted the fix-machinedeployment branch May 14, 2020 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants