This repository was archived by the owner on Aug 12, 2025. It is now read-only.
-
Couldn't load subscription status.
- Fork 42
kubelet runs on master #44
Merged
gianarb
merged 2 commits into
kubernetes-retired:v1alpha3
from
gianarb:feature/kubelet-works-on-mater
May 12, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,13 +175,13 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s | |
|
|
||
| if !machineScope.Cluster.Status.InfrastructureReady { | ||
| machineScope.Info("Cluster infrastructure is not ready yet") | ||
| return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | ||
| return ctrl.Result{}, nil | ||
| } | ||
|
|
||
| // Make sure bootstrap data secret is available and populated. | ||
| if machineScope.Machine.Spec.Bootstrap.DataSecretName == nil { | ||
| machineScope.Info("Bootstrap data secret is not yet available") | ||
| return ctrl.Result{Requeue: true, RequeueAfter: 30 * time.Second}, nil | ||
| return ctrl.Result{}, nil | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question as above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. copied it from aws. It works There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw. But how? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have an answer even for the previous code |
||
| } | ||
|
|
||
| providerID := machineScope.GetInstanceID() | ||
|
|
@@ -203,14 +203,9 @@ func (r *PacketMachineReconciler) reconcile(ctx context.Context, machineScope *s | |
| packet.GenerateMachineTag(mUID), | ||
| packet.GenerateClusterTag(clusterScope.Name()), | ||
| } | ||
| if machineScope.IsControlPlane() { | ||
| tags = append(tags, infrastructurev1alpha3.MasterTag) | ||
| } else { | ||
| tags = append(tags, infrastructurev1alpha3.WorkerTag) | ||
| } | ||
deitch marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| name := machineScope.Name() | ||
| dev, err = r.PacketClient.NewDevice(name, clusterScope.PacketCluster.Spec.ProjectID, machineScope.PacketMachine.Spec, tags) | ||
| dev, err = r.PacketClient.NewDevice(name, clusterScope.PacketCluster.Spec.ProjectID, machineScope, tags) | ||
| if err != nil { | ||
| errs := fmt.Errorf("failed to create machine %s: %v", name, err) | ||
| machineScope.SetErrorReason(capierrors.CreateMachineError) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we no longer requeue? Don't we need to tell it to come back and queue up the request again? Or does the Machine controller change something on the PacketMachine when the cluster is ready? Something has to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied it from aws. It works