Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@cprivitere
Copy link
Contributor

Signed-off-by: Chris Privitere 23177737+cprivitere@users.noreply.github.com

What this PR does / why we need it:
Updates documentation to instruct how to use reserved hardware.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #401

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2022
@cprivitere cprivitere changed the title 📖 📖 Document usage of hardware reservations Sep 7, 2022
@displague
Copy link
Contributor

the commits appear to be duplicated many times here. Let's just squash this down to a single commit or logical commits.

Fix lint issues and add Reserved Instances section
Fix links and lint issues
Remove reservations section
Update spec to current v1beta1
Add reservation example
Fix lint issues
Add  details about facilities and machineTypes
Update wording on Reserved Hardware

Signed-off-by: Chris Privitere <23177737+cprivitere@users.noreply.github.com>
@displague
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cprivitere,displague]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 637701d into kubernetes-retired:main Sep 8, 2022
@cprivitere cprivitere deleted the cprivitere/issue401 branch September 16, 2022 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📖 Improve README.md content

3 participants