This repository was archived by the owner on Aug 12, 2025. It is now read-only.
Add User-Agent to Equinix Metal API calls #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: displague The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
approved
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
user-agent
branch
2 times, most recently
from
f274493 to
3b6a20e
Compare
k8s-ci-robot
added
size/XL
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
k8s-ci-robot
added
size/L
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
k8s-ci-robot
added
size/XXL
cprivitere
reviewed
Jul 14, 2022
There was a problem hiding this comment.
We can't update past kustomize 4.0.4 for now, due to issues with how kustomize renders long lines.
kubernetes-sigs/kustomize#947
It looks like Azure went through a similar set of updates. It looks like they are 4 months and 3 minor releases ahead of that update. I don't see open issues related to it. |
displague
added
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a user-agent string with CAPP and packngo versions embedded. This helps Equinix Metal identify the source and usage of API patterns and errors which greatly helps in debugging and supporting CAPP issues.
Additionally, dependencies have been updated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):