Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@detiber
Copy link
Contributor

@detiber detiber commented Apr 1, 2022

What this PR does / why we need it:

  • Update cluster-api-admins group to reflect current state of the Cluster API Project
  • Update cluster-api-maintainers group to reflect the current state of the Cluster API Project
  • Update cluster-api-packet-maintainers:
    • Remove gianrb, thebsdbox, and mrmrcoleman since they are no longer active in the project
    • Add displague and cprivite for project continuity purposes (detiber leaving Equinix)
  • Update security contacts to reflect current maintainership

Signed-off-by: Jason DeTiberus detiber@users.noreply.github.com

Pending membership for @cprivite here: kubernetes/org#3355

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@detiber
Copy link
Contributor Author

detiber commented Apr 1, 2022

@detiber
Copy link
Contributor Author

detiber commented Apr 1, 2022

Adding hold for 1 week lazy consensus period
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2022
@detiber
Copy link
Contributor Author

detiber commented Apr 1, 2022

/cc @cprivite

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to request PR reviews from the following users: cprivite.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cprivite

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@cprivitere cprivitere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@cprivite: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
Copy link
Contributor

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@displague displague mentioned this pull request Apr 1, 2022
6 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 4, 2022
@detiber
Copy link
Contributor Author

detiber commented Apr 5, 2022

/assign

@detiber
Copy link
Contributor Author

detiber commented Apr 6, 2022

/cc @cprivitere

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to request PR reviews from the following users: cprivitere.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @cprivitere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- Update cluster-api-admins group to reflect current state of the Cluster API Project
- Update cluster-api-maintainers group to reflect the current state of the Cluster API Project
- Update cluster-api-packet-maintainers:
  - Remove gianrb, thebsdbox, and mrmrcoleman since they are no longer active in the project
  - Add displague and cprivite for project continuity purposes (detiber leaving Equinix)
- Update security contacts to reflect current maintainership

Signed-off-by: Jason DeTiberus <detiber@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, detiber, displague

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cprivitere
Copy link
Contributor

/verify-owners

1 similar comment
@cprivitere
Copy link
Contributor

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 11, 2022
@cprivitere
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2022
@cprivitere
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit d4bbdaa into kubernetes-retired:main Apr 11, 2022
@cprivitere cprivitere deleted the addMarques branch April 11, 2022 17:40
@cprivitere cprivitere added this to the 0.6.0 milestone Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants