Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@detiber
Copy link
Contributor

@detiber detiber commented Sep 25, 2021

What this PR does / why we need it:

Cluster API will be releasing v1.0 / v1beta1 support soon

TODO:

  • Update migration tooling to:
    • handle kube-vip migration
    • handle packet-ccm to cpem upgrade
    • remove node providerid migration
  • Verify migration tooling works as expected (preferably through an e2e test)
  • Documentation for upgrade
    • General upgrade docs
    • Multitenancy changes
  • Release notes

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2021
- Add support for provider id changes from packet-ccm to cloud-provider-equinix-metal
- Update version of calico in templates repo to support latest kubernetes releases
- Update templates to deploy cloud-provider-equinix-metal and newer calico
…x Metal cloud provider

Cluster API v1alpha4 changes:
- Update dependencies and make provider changes necessary to support Cluster API v1alpha4
- Rework e2e tests to better leverage upstream e2e test framework and upstream provided test specs
- Rework pr-based github actions to enable smoketesting of PRs using the quickstart e2e test
- Rework push based github actions to enable full e2e tests when changes are merged
- Rework relese workflow to not be dependent on push workflow

Updated cloud-provider support:
- Deploy the latest version of cloud-provider-equinix-metal by default with templates
- Update providerID prefix used from packet:// to equinixmetal:// to align with cloud-provider-equinix-metal
- Provide capp-helper migration tool to support upgrading the cloud provider on existing workload clusters and migrating the providerID for existing Nodes to facilitate migrating from packet-ccm to cloud-provider-equinix-metal

a bit of cleanup

Add additional helpers to wrappedClusterProxy to avoid intermittent issues getting the workload cluster client when handling deletion/remediation of control plane instances

Attempt to cleanup EIPs following e2e tests

Rev cloud-provider-equinix-metal to latest version in templates

Improve cleanup of EIPs following e2e tests

Make EIP cleanup work across ginkgo nodes

Bump packngo to latest

Bump github.com/google/uuid from 1.2.0 to 1.3.0

Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/google/uuid/releases)
- [Commits](google/uuid@v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: github.com/google/uuid
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump github.com/onsi/gomega from 1.15.0 to 1.16.0

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.15.0 to 1.16.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.15.0...v1.16.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

update capi to v0.4.2, update e2e tests accordingly

Fix e2e test configs

stop matrix jobs from failing fast to avoid orphaning resources

Add a cli tool to cleanup CI and a github workflow to run it on a schedule

fix cleanup workflow

Change default instance to c1.small.x86 for e2e tests, allow easier configuration of plan types for e2e tests, and actually show what facility, ssh key, and plans are being used by tests

Reduce duplication of workflows with a composite action

Fixes and further improvements

- Rename ErrorMessage/ErrorReason to align with upstream (which made this change in v1alpha3)
- Add conditions to align with upstream
- Improve re-entrancy of PacketMachine controller, by standardizing tags,
  and doing a lookup by tags if providerID is not recorded
- Enable support for a comma separated list of hardwareReservationIDs

fix up path to action in github workflows

Fixup composite github aciton

fixup go.mod

update generated code

Disable kcp upgrade related tests until they can be deflaked

Allow removing the finalizer for a packetmachine when a machine fails to provision

Fixup ginkgo extra args in makefile

Fix log message

Add a cluster template for no cpem, update cluster template to use kube-vip, and rename e2e test CRS for cni

re-enable kcp-upgrade test

Re-enable all the e2e tests

Update templates, use daemonset for kube-vip, start e2e test for updgrade involving kube-vip

appease linter

patch up e2e test runs with separate module

Add migration tooling to migrate workload clusters to kube-vip

bump controller-runtime and k8s dependencies

Use latest head for cluster-api/test/e2e and add tests for clusters without CPEM enabled

Add PacketCluster to cluster-api category

bump golang to v1.16.8 and move release of capp-helper to container image

Fix pr workflow

manifest fixes

Re-enable scheduled tests, limit concurrency, remove pr-based e2e tests

Restructure templates and e2e tests to enable splitting out tests more granularly for testing

bump dependencies

Improve caching and parallelism for github actions

fix e2e test configs

fix helper after bumping ui dependencies

Fix broken test relese workflow and try to improve tool caching

improve caching for validate test job

fix e2e test template w/ cpem

override default leader election config for kube-vip

fix typo in templates

update e2e test template

switch to static pod manifests

Attempt to improve caching for workflows

fix flavor used for kcp upgrade scale-in testing

Update test configs and calico

fix e2e test configs

Decrease frequency of scheduled ci job to every 6 hours

Switch calico to use vxlan instead of ipip

bump tooling to latest versions

remove helper

update cluster template

update templates

update e2e test templates

update makefile for template changes

more updates to remove helper and serialize e2e tests

fix go mod

more fixes
@detiber detiber force-pushed the capi-v0.5 branch 2 times, most recently from cdd0058 to 0d608d6 Compare September 29, 2021 21:16
@detiber detiber changed the title [WIP] CAPI v1beta4 support [WIP] CAPI v1beta1 support Sep 29, 2021
fix up helper post rebase

bump capi dependency to latest

temp

fix up crd config for v1beta1

add label to tilt configuration
@k8s-ci-robot
Copy link
Contributor

@detiber: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2022
@detiber detiber mentioned this pull request Feb 7, 2022
6 tasks
@detiber
Copy link
Contributor Author

detiber commented Feb 7, 2022

/close
closing in favor of #307

@k8s-ci-robot
Copy link
Contributor

@detiber: Closed this PR.

In response to this:

/close
closing in favor of #307

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants