Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

proper cluster reconcile loop, remove finalizers on delete #26

Merged
merged 1 commit into from
May 6, 2020
Merged

proper cluster reconcile loop, remove finalizers on delete #26

merged 1 commit into from
May 6, 2020

Conversation

@deitch
Copy link
Contributor

@deitch deitch commented May 6, 2020

Does two things:

  • for cluster reconcile, be sure to set the status to ready so it can be used
  • for machine delete, be sure to remove the finalizer once it is deleted

@deitch deitch requested a review from gianarb May 6, 2020 12:41
gianarb
gianarb approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see things coming together!

@gianarb gianarb merged commit 5134d42 into v1alpha3 May 6, 2020
@gianarb gianarb deleted the proper-packetcluster-status branch May 6, 2020 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gianarb gianarb gianarb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deitch @gianarb